This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
Adding dedicated and efficient DAO method to support listing expired … #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+280
to
+289
| public List<String> listExpiringSecretNames(Instant notAfterInclusive) { | ||
| List<String> expiringSecretNames = dslContext | ||
| .select() | ||
| .from(SECRETS) | ||
| .where(SECRETS.CURRENT.isNotNull()) | ||
| .and(SECRETS.EXPIRY.greaterOrEqual(Instant.now().getEpochSecond())) | ||
| .and(SECRETS.EXPIRY.lessThan(notAfterInclusive.getEpochSecond())) | ||
| .fetch(SECRETS.NAME); | ||
| return ImmutableList.copyOf(expiringSecretNames); | ||
| } |
There was a problem hiding this comment.
Simple and straightforward.
| public Iterable<String> secretListingExpiring(@Auth AutomationClient automationClient, @PathParam("time") Long time) { | ||
| public Iterable<String> listExpiringSecretNames(@Auth AutomationClient automationClient, @PathParam("time") Long notAfterInclusiveUnixEpochSeconds) { |
There was a problem hiding this comment.
With anything that has units or denotes a boundary (or both, in this case) I like the name to be very clear about what it is we're dealing with.
graysonchao
approved these changes
Jan 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…secret names