This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
Remove content field from SecretDetailResponseV2 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbpeirce
force-pushed
the
jessep/remove-content-field-in-secret-response-v2
branch
from
8e747c3
to
1aa2a4d
Compare
|
Changes Unknown when pulling 1aa2a4d on jessep/remove-content-field-in-secret-response-v2 into ** on master**. |
|
This looks fine, but I'd like to make sure our clients are updated first, as this is a breaking change. |
SecretDetailResponseV2 is returned only from automation endpoints, which return information on any existing secrets to any automation client. Returning unencrypted secret contents in this situation is dangerous. The content field was never set in Keywhiz, making its presence confusing.
jbpeirce
force-pushed
the
jessep/remove-content-field-in-secret-response-v2
branch
from
de6ba4a
to
7980c91
Compare
mcpherrinm
approved these changes
Apr 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content field in SecretDetailResponseV2 was never set in Keywhiz, making its presence confusing.
SecretDetailResponseV2 is returned from automation endpoints, which return information on any existing secrets to any automation client. Returning unencrypted secret contents in this situation leaks information unnecessarily (note that automation clients can assign secrets to themselves and view the contents using the SecretDeliveryResource, leaving an audit trail in the process).
This PR also removes a pair of constructors for SecretDetailResponseV2 (building it from a Secret and from a SecretSeries) which were unused except in tests. They can be restored easily if necessary.