Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

check-in apidocs formatting #395

Closed
wants to merge 1 commit into from
Closed

Conversation

mbyczkowski
Copy link
Contributor

@mbyczkowski mbyczkowski commented Nov 21, 2018

I believe my pre-commit hooks removed newlines and javadocs keeps generating them. This should fix an issue we still have in #392

@coveralls
Copy link

coveralls commented Nov 21, 2018

Coverage Status

Coverage remained the same at 74.209% when pulling 17a0a28 on mbyczkowski/apidocs into 7c3c3a0 on master.

@igorshcheglakov
Copy link
Contributor

The ones with new line have gone but one more left:

~/projects/Git/keywhiz-square (mbyczkowski/apidocs)$ git status
Changes not staged for commit:
	modified:   docs/apidocs/service.json
~/projects/Git/keywhiz-square (mbyczkowski/apidocs)$ git diff
diff --git a/docs/apidocs/service.json b/docs/apidocs/service.json
index c5cfe21..7664748 100644
--- a/docs/apidocs/service.json
+++ b/docs/apidocs/service.json
@@ -6,12 +6,12 @@
     "path" : "/secrets-admin.{format}",
     "description" : "Create, retrieve, and delete secrets"
   }, {
-    "path" : "/login.{format}",
-    "description" : "Login to Keywhiz admin interface"
-  }, {
     "path" : "/automation_v2-backup.{format}",
     "description" : "Automation endpoints for backups"
   }, {
+    "path" : "/login.{format}",
+    "description" : "Login to Keywhiz admin interface"
+  }, {
     "path" : "/logout.{format}",
     "description" : "Logout from the Keywhiz admin interface"
   }, {

Copy link
Contributor

@alokmenghrajani alokmenghrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbyczkowski
Copy link
Contributor Author

we've decided to remove API docs instead (see #402)

@mbyczkowski mbyczkowski deleted the mbyczkowski/apidocs branch August 1, 2019 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants