Set source and target compatibility for KotlinCompile tasks #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this affects the metadata, or at least i'm not sure. I would think that you would have to set it on the java convention / extension. |
|
I'll test it some time later. |
Egorand
force-pushed
the
egorand/201015/source-target-compat
branch
from
11ee2a3
to
79e5dcd
Compare
|
@JakeWharton PTAL, verified this locally. |
JakeWharton
approved these changes
Oct 20, 2020
| @@ -44,6 +44,11 @@ subprojects { | |||
| freeCompilerArgs = listOf("-Xopt-in=kotlin.RequiresOptIn") | |||
| } | |||
| } | |||
| // Ensure "org.gradle.jvm.version" is set to "8" in Gradle metadata. | |||
| tasks.withType<JavaCompile> { | |||
| sourceCompatibility = JavaVersion.VERSION_1_8.toString() | |||
There was a problem hiding this comment.
I'm not sure you need toString(), but it doesn't really matter.
There was a problem hiding this comment.
With Kotlin DSL you do, sadly. We need setter overloads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #999