Remove Filer writing and originating elements concept.

[JakeWharton]

These stem from javac annotation processors inside which Kotlin cannot be generated.

[ZacSweers]

all red diffs are the best diffs

[max4t]

Hi, if you don't mind me asking : why removing the writeTo(Filer)?
I've created an annotation processor for android which generates kotlin files to Filer.createResource(SOURCE_OUTPUT, ...) and it works like a charm.
I was hoping to use writeTo(Filer) when switching to kotlinPoet

[JakeWharton]

javac can't compile kotlin code so that method is useless.

…

On Fri, Jun 2, 2017 at 11:43 AM Maxime Toumi ***@***.***> wrote: Hi, if you don't mind me asking : why removing the writeTo(Filer)? I've created an annotation processor for android which generates kotlin files to Filer.createResource(SOURCE_OUTPUT, ...) and it works like a charm. I was hoping to use writeTo(Filer) when switching to kotlinPoet — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#93 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEf1lYgCH7wm4ncyAnnaHLYpMGnaXks5sAC2QgaJpZM4Nl9eE> .

[max4t]

javac can't for sure but i'm using android studio 3 (canary) and the default kotlin buildchain compile the generated kotlin files in Filer.createResource(SOURCE_OUTPUT, ...)

[JakeWharton]

Please provide a sample which demonstrates this behavior

…

On Fri, Jun 2, 2017 at 12:35 PM Maxime Toumi ***@***.***> wrote: javac can't for sure but i'm using android studio 3 (canary) and the default kotlin buildchain compile the generated kotlin files in Filer.createResource(SOURCE_OUTPUT, ...) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#93 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEES6ZU23Wkk7toUDDVuYL6ME_2WLOks5sADnbgaJpZM4Nl9eE> .

[max4t]

Here is a sample :

• In app/build/generated/source/kapt/debug/com/example/extension/MakerExtension.kt (generated):

...
fun Maker.getDummy() = "Test String"
...

• In app/src/main/java/com/example/MainActivity.kt:

@MakerAnnotation
class MainActivity : AppCompatActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(R.layout.activity_main)
        (findViewById(R.id.txt_view) as TextView).text = Maker().getDummy()
    }
}

P.S.: the MakerAnnotation is what generates MakerExtension.kt
P.S.2: in the processor, i have :

private fun getWriter() : Writer = processingEnv.filer.createResource(
            StandardLocation.SOURCE_OUTPUT, "com.example.extension", "MakerExtension.kt").openWriter()

[JakeWharton]

I mean an executable sample

…

On Fri, Jun 2, 2017 at 12:40 PM Maxime Toumi ***@***.***> wrote: Here is a sample : - In app/build/generated/source/kapt/debug/com/example/extension/ViewMakerExtension.kt (generated): ...fun Maker.getDummy() = "Test String"... - In app/src/main/java/com/example/MainActivity.kt: class MainActivity : AppCompatActivity() { override fun onCreate(savedInstanceState: Bundle?) { super.onCreate(savedInstanceState) setContentView(R.layout.activity_main) (findViewById(R.id.txt_view) as TextView).text = Maker().getDummy() } } — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#93 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEcByeKCyRJsLEbItsJUNrSwAxEUfks5sADsAgaJpZM4Nl9eE> .

[max4t]

Here is the sample
The class MainActivity set the text of the textView using the generated function

[JakeWharton]

Wow interesting! I've never used kapt. I'm surprised it does this. We potentially might want to revert this then.

…

On Fri, Jun 2, 2017 at 2:02 PM Maxime Toumi ***@***.***> wrote: Here is the https://github.com/max4t/KotlinGeneratingProcessor <http://sample> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#93 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEe7Qgi_uaPe6uuMo1cttKziAdMJdks5sAE5RgaJpZM4Nl9eE> .

[max4t]

Thanks that would be great.

It works because kapt.generateStubs = true in app/build.gradle otherwise you get an missing reference.
I don't remember exactly how it works but if i recall correctly kapt generated the references (the stubs) without content so that javac doesn't complain and then all is linked at the end or something like that

[JakeWharton]

Hmm that's kapt1 though which is deprecated. Does it work with kapt3?

…

On Fri, Jun 2, 2017 at 3:19 PM Maxime Toumi ***@***.***> wrote: Thanks that would be great. It works because kapt.generateStubs = true in app/build.gradle otherwise you get an missing reference. I don't remember exactly how it works but if i recall correctly kapt generated the references (the stubs) without content so that javac doesn't complain and then all is linked at the end or something like that — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#93 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEXQ2mRwbqjCmibkaJqCNDoNJI3nwks5sAGAlgaJpZM4Nl9eE> .

[max4t]

It seems like by default kapt1 is used. kapt3 is available by adding apply plugin: 'kotlin-kapt'

With apply plugin: 'kotlin-kapt', this block (in app/build.gradle):

kapt {
    generateStubs = true
}

is useless (as announced in the blog paragraph New Experimental Annotation Processing)

[hotchemi]

Hi @JakeWharton @max4t any update here?
I just found official Kotlin code generation example and it seems works well with the latest Kotlin and kapt ver. https://github.com/JetBrains/kotlin-examples/tree/master/gradle/kotlin-code-generation