Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert LeakCanary to Kotlin #1205

Closed
pyricau opened this issue Mar 19, 2019 · 4 comments
Closed

Convert LeakCanary to Kotlin #1205

pyricau opened this issue Mar 19, 2019 · 4 comments

Comments

@pyricau
Copy link
Member

pyricau commented Mar 19, 2019

  1. Update build files to add kotlin support and convert 1 small class to show it wors
  2. Convert everything, a few classes at a time. It's important to do small PRs because a.lot of changes could happen at the same time.
@pyricau pyricau added this to the 2.0 milestone Mar 19, 2019
@pyricau pyricau changed the title Convert LeakCanary in Kotlin Convert LeakCanary to Kotlin Mar 19, 2019
@codedsun
Copy link

codedsun commented Mar 27, 2019

Hey @pyricau , can I know the details for this issue? I am looking to contribute for this!

@pyricau
Copy link
Member Author

pyricau commented Mar 28, 2019

@codedsun I'll be spending a hackweek on LeakCanary 2 which will be a somewhat large rewrite, and as part of that I want to introduce Kotlin for new code and later progressively convert the rest of it.

I need to figure out the gradle config changes I need to get kotlin going and then any PR that converts any class is welcome.

Since I'll be working on LeakCanary 2 I have on concerns with backward compatibility of the API, it'll likely all change, including the package.

@codedsun
Copy link

No issues! @pyricau . I am little more excited about the hack week you are talking about..Can I also contribute for that or anything else lined up that I can take for now?

@pyricau
Copy link
Member Author

pyricau commented Mar 28, 2019

I'm happy to get contributions! Our HackWeek is next week and I'll be focused on that, help welcome!

I started writing the high level in #1211, I'll still need to hash it out to smaller bits / how to organize the work

@pyricau pyricau mentioned this issue Mar 29, 2019
colinmarsch added a commit that referenced this issue Apr 1, 2019
pyricau pushed a commit that referenced this issue Apr 1, 2019
colinmarsch added a commit that referenced this issue Apr 2, 2019
colinmarsch added a commit that referenced this issue Apr 2, 2019
colinmarsch added a commit that referenced this issue Apr 3, 2019
colinmarsch added a commit that referenced this issue Apr 3, 2019
pyricau pushed a commit that referenced this issue Apr 3, 2019
* Convert support-fragment to Kotlin

See #1205

* Use extension functions in Fragments.kt
pyricau added a commit that referenced this issue Apr 5, 2019
pyricau added a commit that referenced this issue Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants