Fragment RefWatcher OnDestroyView

[eygraber]

The wiki says that RefWatcher.watch should be called in onDestroyView when watching a Fragment. Why not onDestroy?

[JakeWharton]

For the fragment instance, yes. For the fragment's view tree, no. The wiki looks wrong as-is though.

…

On Wed, Aug 2, 2017, 9:32 AM Eliezer Graber ***@***.***> wrote: The wiki <https://github.com/square/leakcanary/wiki/FAQ#how-do-i-use-it> says that RefWatcher.watch should be called in onDestroyView when watching a Fragment. Why not onDestroy? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#806>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEcAC-L-7QoJyLHOZbvrYxj_46nddks5sUHprgaJpZM4OrGKB> .

[eygraber]

@JakeWharton thanks for the answer, but not sure I understand the yes and no. Why not onDestroy for the instance?

[JakeWharton]

That's what I said yes to

…

On Wed, Aug 2, 2017, 10:35 AM Eliezer Graber ***@***.***> wrote: @JakeWharton <https://github.com/jakewharton> thanks for the answer, but not sure I understand the yes and no. Why not onDestroy for the instance? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#806 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEETjeEeR0g4ql61uHWekZYVqiUFxkks5sUIkXgaJpZM4OrGKB> .

[eygraber]

Sorry I'm running on 0 sleep and 0 coffee 😵

You're saying yes, the instance should be watched in onDestroy, and the view should be watched in onDestroyView?

[JakeWharton]

Updated

[eygraber]

@JakeWharton is there any need to watch the fragment's view in onDestroyView?

[JakeWharton]

Only if it's a retained fragment.

…

On Thu, Aug 3, 2017 at 5:57 PM Eliezer Graber ***@***.***> wrote: @JakeWharton <https://github.com/jakewharton> is there any need to watch the fragment's view in onDestroyView? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#806 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEUe1-6ecbjnN5idqSA6Wa6SQpCP7ks5sUkJCgaJpZM4OrGKB> .