Reshaping exclusions #1465
Merged
Reshaping exclusions #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pyricau
commented
Jul 15, 2019
pyricau
commented
- Now known as "ReferenceMatcher" which is either a LibraryLeakReferenceMatcher or a IgnoredReferenceMatcher
- The patterns are in ReferencePattern
- Removed the bad mess with the extra layer of priority. Should always have stuck to ignored vs library leak
- Using graph context to store build mirror, makes so much more sense.
- Moved library leaks from living within the leaktrace to becoming a top level object (first library leak matched) and removed other related classes
* Now known as "ReferenceMatcher" which is either a LibraryLeakReferenceMatcher or a IgnoredReferenceMatcher * The patterns are in ReferencePattern * Removed the bad mess with the extra layer of priority. Should always have stuck to ignored vs library leak * Using graph context to store build mirror, makes so much more sense. * Moved library leaks from living within the leaktrace to becoming a top level object (first library leak matched) and removed other related classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.