Issue #2079. Fix a crash when targeting Android 12 #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
leakcanary-android-core/src/main/java/leakcanary/internal/NotificationReceiver.kt
Outdated
Show resolved
Hide resolved
ihrupin
force-pushed
the
main
branch
4 times, most recently
from
8079aab
to
223762f
Compare
…rash when targeting Android 12
|
@pyricau Please review the PR. Thank you! |
ihrupin
commented
Mar 19, 2021
| @@ -39,7 +40,12 @@ internal class NotificationReceiver : BroadcastReceiver() { | |||
| ): PendingIntent { | |||
| val broadcastIntent = Intent(context, NotificationReceiver::class.java) | |||
| broadcastIntent.action = action.name | |||
| return PendingIntent.getBroadcast(context, 0, broadcastIntent, 0) | |||
| val flags = if (Build.VERSION.SDK_INT > 30) { | |||
There was a problem hiding this comment.
Using Build.VERSION_CODES.R instead of "30" requires updating compileSDK from 29 to 30. This update caused other issues. So, it is better to do compileSDK update in a separate PR
pyricau
approved these changes
Mar 24, 2021
|
thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Android 12 we need to set PendingIntent mutability explicitly.
Here is the documentation: https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability
Error message:
Targeting S+ (version 10000 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent. Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.Fixes Issue #2079