ignore Meizu RecommendActivity leaked in Android Instrumentation #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyricau
reviewed
Sep 18, 2016
| @@ -442,6 +443,13 @@ | |||
| excluded.instanceField("android.view.Choreographer$FrameDisplayEventReceiver", | |||
| "mMessageQueue").alwaysExclude(); | |||
| } | |||
| }, | |||
|
|
|||
| INSTRUMENTATION_RECOMMEND_ACTIVITY(MEIZU.equals(MANUFACTURER)) { | |||
There was a problem hiding this comment.
Can you move this closer to the top, next to the other manufacturer ignored leaks? Also please hide a version range check (SDK_INT)
There was a problem hiding this comment.
Do you mean a version check should be added also?
|
Sorry, I force updated commit after rebase with lastest remote code. it seems this pr closed. |
|
I have pushed new commits as you requested. Please check. |
pyricau
reviewed
Sep 19, 2016
| @@ -305,6 +306,14 @@ | |||
|
|
|||
| // ######## Manufacturer specific Excluded refs ######## | |||
|
|
|||
| INSTRUMENTATION_RECOMMEND_ACTIVITY(MEIZU.equals(MANUFACTURER) && SDK_INT >= LOLLIPOP) { | |||
There was a problem hiding this comment.
Should not be SDK_INT >= LOLLIPOP. Only target the versions you know for sure are impacted.
There was a problem hiding this comment.
OK. I will change this
|
Thx! Can you squash all commits into one? |
…ndroid 5.0 and 5.1
|
squash done. please check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running UI automation tests using Instrumentation on Meizu devices, some page would report a memory leak in
I digged and found
RecommendActivityis a class inframework.jarin Meizu FlymeOS (smali source). I do not know what it does and when it would be invoked. Maybe it relates to permission alerts prompted by FlymeOSBut I found many people got this memory leak.(google result) I also reported an issue #590 . and found a similar issue earlier #506