perf(image): update css for perf on safari #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed Styleguide and Lab. Notes
|
|
Have you tested in other browsers to make sure these changes don't cause any issues? |
Yup, Chrome, Safari, and FF. |
wkashdan
approved these changes
Dec 12, 2023
pretzelhammer
approved these changes
Dec 12, 2023
|
🎉 This PR is included in version 19.6.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the problem this PR addresses
Noticed on our OO sites in Safari removing the images vastly improved the scroll experience. From there it was just removing attributes and CSS until I narrowed it down to the
height: 100%seemingly causing the issue. Will see if the deployed version provides the same perf gain.Describe the changes in this PR
Use
inheritinstead of100%and remove the parentspanas that causes perf issues.imgneeds to be a direct child of thediv.