fix(icon): fix default icon color inheritence #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed Styleguide and Lab. Notes
|
pretzelhammer
approved these changes
Jun 23, 2023
|
🎉 This PR is included in version 18.0.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the problem this PR addresses
This fixes an icon color bug. Icons with no
colorprop declared are not inheriting the parent color as desired, but inheriting the nearest parent definition of--color, which typically happens on the nearest MTheme. This causes a bug on button loaders where instead of applying the button color, it applies the MTheme color instead.Describe the changes in this PR
This PR replaces
--color: inheritwith--color: currentColor, which fixes the color inheritance bug.Other information