Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toast): add icon size prop #581

Merged
merged 1 commit into from
Jul 9, 2024
Merged

feat(toast): add icon size prop #581

merged 1 commit into from
Jul 9, 2024

Conversation

mattmewton
Copy link
Contributor

Describe the problem this PR addresses

The MToast component uses an MIcon component under the hood. Since the default size for MIcon is small, all of the toast icons are also small.

Describe the changes in this PR

Added an icon-size property to allow devs to control the size of the toast icons.

Example with icon-size="medium"

Before:
Screenshot 2024-07-08 at 4 34 50 PM

After:
Screenshot 2024-07-08 at 4 37 44 PM

Other information

@mattmewton mattmewton requested review from a team as code owners July 8, 2024 20:38
@mattmewton mattmewton requested a review from wkashdan July 8, 2024 20:39
@mattmewton mattmewton changed the title feat:(MToast): add icon size prop feat(MToast): add icon size prop Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

Deployed Styleguide and Lab.

Notes
  1. Links may take a few minutes to update after PR is opened or commit is pushed.
  2. Links may become invalidated after PR is merged or closed.
  3. Links for all releases and open PRs can be found on the Maker Deploys page.

@pretzelhammer pretzelhammer changed the title feat(MToast): add icon size prop feat(toast): add icon size prop Jul 9, 2024
@mattmewton mattmewton merged commit 1ecda79 into master Jul 9, 2024
4 checks passed
@mattmewton mattmewton deleted the toast-icon-size branch July 9, 2024 14:49
Copy link

github-actions bot commented Jul 9, 2024

🎉 This PR is included in version 19.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants