Update Go versions and vendor using Godep (and fix the build) #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move to the standard library context package
DanielNi
changed the title
drcapulet
reviewed
Jun 20, 2017
| @@ -15,6 +15,7 @@ | |||
| package command | |||
|
|
|||
| import ( | |||
| netcontext "context" | |||
There was a problem hiding this comment.
I think we could probably remove the netcontext here?
|
@drcapulet I guess we could import the peg library somewhere (maybe in |
|
Godep will only vendor imported packages, not commands. I wouldn't want to roll something on our own here just to get a stable copy of That Travis CI build issue you mentioned is from 2015. How has this project not run into this problem before? |
bwester
approved these changes
Jun 20, 2017
|
Looking at previous builds, it looks like Cassandra has always failed to start up, but the tests still passed somehow. Maybe something in the newer versions of Go causes the tests to fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of this to get the build to pass...