Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dummy loading UI for config tab and a timeout for the error component #776

Closed
adrw opened this issue Feb 11, 2019 · 2 comments
Closed

Add dummy loading UI for config tab and a timeout for the error component #776

adrw opened this issue Feb 11, 2019 · 2 comments
Labels
frontend Typescript, React, Webpack and everything Admin dashboard

Comments

@adrw
Copy link
Collaborator

adrw commented Feb 11, 2019

Confusing right now to have error show for the split second while the request to ConfigAdminAction loads. Dummy UI is a better solution so that UI shows instantly and seamlessly transitions when the data arrives. Add a timeout to error component so it only shows after a few seconds.
@adrw adrw added the frontend Typescript, React, Webpack and everything Admin dashboard label Feb 11, 2019
@adrw
Copy link
Collaborator Author

adrw commented Feb 11, 2019

Timeout with error component dependent on this landing cashapp/misk-web#153

@adrw
Copy link
Collaborator Author

adrw commented Oct 21, 2019

Merged in bump to Misk-Web 0.1.19

@adrw adrw closed this as completed Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend Typescript, React, Webpack and everything Admin dashboard
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adrw