No, don't takeView in onFinishInflate

Note that none of the sample code does.
square · Sep 18, 2015 · 0737c17 · 0737c17
1 parent 6a5f8a0
commit 0737c17
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/mortar-sample/src/main/java/com/example/mortar/screen/FramePathContainerView.java b/mortar-sample/src/main/java/com/example/mortar/screen/FramePathContainerView.java
@@ -56,10 +56,6 @@ protected FramePathContainerView(Context context, AttributeSet attrs, PathContai
     return this;
   }
 
-  @Override protected void onFinishInflate() {
-    super.onFinishInflate();
-  }
-
   @Override public void dispatch(Flow.Traversal traversal, final Flow.TraversalCallback callback) {
     disabled = true;
     container.executeTraversal(this, traversal, new Flow.TraversalCallback() {

diff --git a/mortar/src/main/java/mortar/Presenter.java b/mortar/src/main/java/mortar/Presenter.java
@@ -51,9 +51,8 @@ public abstract class Presenter<V> {
   };
 
   /**
-   * Called to give this presenter control of a view, ideally from {@link
-   * android.view.View#onFinishInflate}. If a view is to be re-used, make an additional call from
-   * {@link android.view.View#onAttachedToWindow()}. (Redundant calls will safely no-op.) Sets the
+   * Called to give this presenter control of a view, typically from 
+   * {@link android.view.View#onAttachedToWindow()}. Sets the
    * view that will be returned from {@link #getView()}.
    * <p/>
    * This presenter will be immediately {@link BundleService#register registered}