Allow services to be scoped. #133
Conversation
BundleServiceRunner uses this to minimize the keys it writes to the bundle, thus keeping it safe for apps to use crazy transient values like task-id in their activity scope names.
| * Makes this service available via the new scope's {@link MortarScope#findService} | ||
| * method. If the service implements {@link Scoped} it will be registered with | ||
| * the new scope. | ||
| */ | ||
| public Builder withService(String serviceName, Object service) { |
There was a problem hiding this comment.
what's the use case for a service that doesn't want to implement Scoped?
There was a problem hiding this comment.
I wasn't a fan of the hidden behavior in register() where the Scoped was also a Bundle... compile time APIs are much clearer and safe than javadoc.
There was a problem hiding this comment.
Re: use case, neither dagger service needs it. I suspect most won't.
I can add a withScopedService(String, Scoped)
There was a problem hiding this comment.
discussed offline, but for the record: now tend to agree with PY, a second method with a Scoped param is probably better than the instanceof check. The method w/ Object could do an instanceof check to guard against accidental usage of the wrong method.
|
LGTM |
BundleServiceRunner uses this to minimize the keys it writes
to the bundle, thus keeping it safe for apps to use crazy
transient values like task-id in their activity scope names.