Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BundleServiceComparator): use ternary operator instead of Integer#compare() that requires API level 19 #144

Merged
merged 1 commit into from
Apr 28, 2015

Conversation

DmitriyZaitsev
Copy link

Hi! I suggest to replace Integer.compare with ternary operator:

  • That method added in API level 19 but Mortar supports much lower API versions;
  • Since in this block array lengths are different, so result can be only 1 or -1 and now it's more obvious for reading.

@rjrjr
Copy link
Collaborator

rjrjr commented Apr 27, 2015

Wow, that's nuts. Thanks for the fix, but please sign our CLA so that I can merge it. https://github.com/square/mortar/blob/master/CONTRIBUTING.md

@DmitriyZaitsev
Copy link
Author

I've signed it. Thanks.

rjrjr added a commit that referenced this pull request Apr 28, 2015
fix(BundleServiceComparator): use ternary operator instead of Integer#compare() that requires API level 19
@rjrjr rjrjr merged commit 6c2d802 into square:master Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants