Don't make dead scopes disappear. #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LG |
rjrjr
force-pushed
the
ray/can-still-get-dead-scope
branch
from
eebc63f
to
22c1e08
Compare
| * registration list. Recursively destroys all children. Parent scope drops its reference | ||
| * to this instance. Redundant calls to this method are safe. | ||
| * Sends {@link Scoped#onExitScope()} to all registrants and then clears the registration list | ||
| * and drops references to provided services. Parent scope drops its reference to this instance. |
There was a problem hiding this comment.
Do we need/want to guarantee dropping service references? I'd kinda prefer not to.
|
one note, LG otherwise. |
#168 Also moves some test cases out of mortar-dagger1 and into MortarScopeTest, and copies BundleServiceTest from nasty old MortarActivityScope test (which needs killing).
rjrjr
force-pushed
the
ray/can-still-get-dead-scope
branch
from
22c1e08
to
aaa1d00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#168
Also moves some test cases out of mortar-dagger1 and into
MortarScopeTest, and copies BundleServiceTest from nasty old
MortarActivityScope test (which needs killing).