Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme incorrectly says Rfc3339DateJsonAdapter isn't null-safe #1003

Closed
dvdmunckhof opened this issue Nov 4, 2019 · 1 comment · Fixed by #1073
Closed

Readme incorrectly says Rfc3339DateJsonAdapter isn't null-safe #1003

dvdmunckhof opened this issue Nov 4, 2019 · 1 comment · Fixed by #1073
Labels
documentation
Milestone
1.10

Comments

@dvdmunckhof
Copy link

The Adapter Convenience Methods section in the readme says:

RFC 3339 date adapter, doesn't support null by default
See also: https://github.com/square/moshi/tree/master/adapters

However, this commit made Rfc3339DateJsonAdapter null-safe. The readme should be updated to reflect this change.
@ZacSweers
Copy link
Collaborator

Can fix!

@swankjesse swankjesse added this to the 1.10 milestone Nov 17, 2019
ZacSweers added a commit that referenced this issue Jan 15, 2020
@ZacSweers
Tweak README nullSafe() example
da01649 
Resolves #1003
@ZacSweers ZacSweers mentioned this issue Jan 15, 2020
Merged
ZacSweers added a commit that referenced this issue Jan 15, 2020
@ZacSweers
Tweak README nullSafe() example (#1073)
52cf86d 
Resolves #1003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
1.10
Development

Successfully merging a pull request may close this issue.

Tweak README nullSafe() example square/moshi
3 participants
@swankjesse @ZacSweers @dvdmunckhof