Fix dualkotlintest #1064
Closed
Fix dualkotlintest #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a little optimization to save doing this reflective attempt before other types that can't be generated, like lists/arrays/maps/etc
rharter
approved these changes
Jan 13, 2020
|
If this is just for the test, I wonder if there's a way to either make the test more representative by breaking out the functional reflection test into it's own module that doesn't include codegen, or using some internal constant or something that the compiler can optimize away, so we don't add an if check and constructor param confusion, adding complexity to the code for a test case. |
|
Yeah it's kind of just for the test. Breaking out tests would be a lot of duplication. Maybe just a simple internal backdoor but there's no package private in Kotlin :/ |
|
I haven't found a good way to do this in Kotlin. Wish I had some idea to
help.
…On Mon, Jan 13, 2020 at 11:09 AM Zac Sweers ***@***.***> wrote:
Yeah it's kind of just for the test. Breaking out tests would be a lot of
duplication. Maybe just a simple internal backdoor but there's no package
private in Kotlin :/
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1064?email_source=notifications&email_token=AAJ4S3WGUILH6XRTDGIP323Q5SN4FA5CNFSM4KFUIWBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIZQMYQ#issuecomment-573769314>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ4S3UCIA53EHFH4AIX2RDQ5SN4FANCNFSM4KFUIWBA>
.
|
|
I've got another idea. Involves a backdoor but it's at least not public API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't actually running reflection before because the reflection adapter will use generated adapters anyway if available. I've added an overload that allows controlling this behavior (default is enabled), as I'm not sure how else to set this up.
This also makes an opportunistic optimization to defer checking for generated classes until just before the ClassJsonAdapter, as it avoids unnecessary reflection checks before other non-generatable-types like collections/maps/arrays.