Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mangle property names that contain a dollar sign #1446

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

swankjesse
Copy link
Collaborator

Without this fix the new test fails like this:

value of: toJson(...)
expected: {"$a":"apple","$b":"banana"}
but was : {"${'$'}a":"apple","$b":"banana"}

@swankjesse swankjesse force-pushed the jwilson.1205.dollar_sign_in_property_name_ branch from 4eccf77 to 59c16a1 Compare December 6, 2021 01:26
Without this fix the new test fails like this:

    value of: toJson(...)
    expected: {"$a":"apple","$b":"banana"}
    but was : {"${'$'}a":"apple","$b":"banana"}
@swankjesse swankjesse force-pushed the jwilson.1205.dollar_sign_in_property_name_ branch from 59c16a1 to d3baa94 Compare December 6, 2021 01:34
@swankjesse
Copy link
Collaborator Author

Ooooh tests show we also had this bug in Kapt! Yay bug compatibility!

@swankjesse swankjesse merged commit bc441ad into master Dec 6, 2021
@swankjesse swankjesse deleted the jwilson.1205.dollar_sign_in_property_name_ branch December 6, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants