Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin Code Gen module #435

Merged
merged 93 commits into from
Mar 12, 2018
Merged

Kotlin Code Gen module #435

merged 93 commits into from
Mar 12, 2018

Commits on Feb 15, 2018

  1. Add kotlin code gen modules

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    fc927f1 View commit details
    Browse the repository at this point in the history

  2. Update kotlin to 1.2

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    fabdf13 View commit details
    Browse the repository at this point in the history

  3. Add a serializable dummy class

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    c16bd74 View commit details
    Browse the repository at this point in the history

  4. Try using kapt configuration from kotlin-examples repo 

    Still no luck!
    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    5629bb9 View commit details
    Browse the repository at this point in the history

  5. Use proper allocated name for assignment too

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    8b84f7a View commit details
    Browse the repository at this point in the history

  6. Use selectName() API

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    6c32fb7 View commit details
    Browse the repository at this point in the history

  7. Clean up constructor parameter annotations & plumbing for qualifiers

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    221b9b3 View commit details
    Browse the repository at this point in the history

  8. Updates poms and kotlin code gen processor to support tests.

    @rharter @ZacSweers
    rharter authored and ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    d9303d3 View commit details
    Browse the repository at this point in the history

  9. Ignore kotlin code gen tests for now 

    None of these are data classes tests right now, which is the only thing this supports right now
    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    f39f3fc View commit details
    Browse the repository at this point in the history

  10. Replace $ with _ in class names for consistency

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    f45e0ff View commit details
    Browse the repository at this point in the history

  11. Shortcut Array types to arrayOf

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    4c2b044 View commit details
    Browse the repository at this point in the history

  12. Add DataClassTest

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    a2dd477 View commit details
    Browse the repository at this point in the history

  13. Try generated option first, fall back to maven after

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    380a3a2 View commit details
    Browse the repository at this point in the history

  14. More idiomatic handling

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    316eb77 View commit details
    Browse the repository at this point in the history

  15. Only use nonnullable types for adapter properties

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    9c98c37 View commit details
    Browse the repository at this point in the history

  16. Code dump of kotshi tests

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    35ef68c View commit details
    Browse the repository at this point in the history

  17. Comment out specifics to get compiling

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    36689ab View commit details
    Browse the repository at this point in the history

  18. Generics support!

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    592a08e View commit details
    Browse the repository at this point in the history

  19. Fix double primitive default

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    3a1d735 View commit details
    Browse the repository at this point in the history

  20. Pick up temporary snapshot for Any fix

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    15d556c View commit details
    Browse the repository at this point in the history

  21. Invariance should just be null

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    94d05c0 View commit details
    Browse the repository at this point in the history

  22. Better handling of nullably-bound variance

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    8cc2d81 View commit details
    Browse the repository at this point in the history

  23. Just assume the first jvm constructor for now as jvmMethodSig is flaky

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    9c98105 View commit details
    Browse the repository at this point in the history

  24. Specify types param if needed

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    81287b7 View commit details
    Browse the repository at this point in the history

  25. Don't do lazy delegation

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    8614325 View commit details
    Browse the repository at this point in the history

  26. Clean up nullable typevariablename boundaries

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    6825d69 View commit details
    Browse the repository at this point in the history

  27. Add type variables to extension function on companion object

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    00087b9 View commit details
    Browse the repository at this point in the history

  28. Use properties instead of allocated names for more robustness 

    Since we're already on a snapshot
    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    f894c6c View commit details
    Browse the repository at this point in the history

  29. If there are no type variables, make it null for simpler handling

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    af945d3 View commit details
    Browse the repository at this point in the history

  30. Fix generics and Type[] handling

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    980016e View commit details
    Browse the repository at this point in the history

  31. Fix unnecessary as casts on primitive defaults

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    e9c1bb3 View commit details
    Browse the repository at this point in the history

  32. Reference spec directly for possible bangs

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    c3533dc View commit details
    Browse the repository at this point in the history

  33. Use nullSafe() adapters for anything nullable or with default values

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    7cded10 View commit details
    Browse the repository at this point in the history

  34. Use object type in makeType() 

    Types.java cares
    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    d952e02 View commit details
    Browse the repository at this point in the history

  35. Make TestPrimitiveDefaultValues work

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    a225bf5 View commit details
    Browse the repository at this point in the history

  36. Re-enable TestClassWithJavaKeyword

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    615325c View commit details
    Browse the repository at this point in the history

  37. Ignore remaining tests that are pending decisions or JsonQualifier su… 

    …pport
    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    2b5da41 View commit details
    Browse the repository at this point in the history

  38. Remove customnames test as we're just going to stick with simple @JSON

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    b94d565 View commit details
    Browse the repository at this point in the history

  39. Add toString() implementations

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    0973769 View commit details
    Browse the repository at this point in the history

  40. Reenable default values testing, adapt to kotlin lang support

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    96d0651 View commit details
    Browse the repository at this point in the history

  41. Remove primitive adapters bits since we're not using it

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    7271942 View commit details
    Browse the repository at this point in the history

  42. Clean up a bunch of leftover comments

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    266bceb View commit details
    Browse the repository at this point in the history

  43. Switch to only nullable handling, report missing properties 

    This makes all nullable handling for local properties the same, and removes defaults for primitives in the process. It simplifies the handling a lot, and leans on kotlin language features to take care of null handling (null checking and then throwing the lazily evaluated list of missing properties).

One minor change from what kotshi does - this reports the serialized name in the missing properties, not the property name. We could look at supporting this though if we want.
    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    494a682 View commit details
    Browse the repository at this point in the history

  44. Implement JsonQualifier support

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    f8d5833 View commit details
    Browse the repository at this point in the history

  45. Use Kapt for AutoService/processor declaration

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    2cf7cfb View commit details
    Browse the repository at this point in the history

  46. Checkstyle

    @ZacSweers
    ZacSweers committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    d13c494 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2018

  1. Remove unused primite type checks

    @ZacSweers
    ZacSweers committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    0de2157 View commit details
    Browse the repository at this point in the history

  2. Add test verifying mutable and immutable collections work

    @ZacSweers
    ZacSweers committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    b218363 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2018

  1. Fix test name

    @ZacSweers
    ZacSweers committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    49004ad View commit details
    Browse the repository at this point in the history

  2. Standardize isRequired checks

    @ZacSweers
    ZacSweers committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    57a3332 View commit details
    Browse the repository at this point in the history

  3. Add more nullability and mutability tests

    @ZacSweers
    ZacSweers committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    6c134a3 View commit details
    Browse the repository at this point in the history

  4. Kotlinpoet 0.7.0 final

    @ZacSweers
    ZacSweers committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    e2b1be0 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2018

  1. Switch to new vararg overload for annotation class adapter()

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    7461d68 View commit details
    Browse the repository at this point in the history

  2. Make suffix just JsonAdapter without underscore

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    d6e8a84 View commit details
    Browse the repository at this point in the history

  3. Switch to just a regular constructor for MoshiSerializableFactory

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    4a91af8 View commit details
    Browse the repository at this point in the history

  4. Remove constructor caching

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    c95a2b9 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary framework class checks

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    c69c477 View commit details
    Browse the repository at this point in the history

  6. Nix unnecessary superclass lookups, inline constructor lookup

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    b9b2527 View commit details
    Browse the repository at this point in the history

  7. Nix null token check in reads

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    90436da View commit details
    Browse the repository at this point in the history

  8. Nix null check in writes, do !! on first value use

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    8eb5bb4 View commit details
    Browse the repository at this point in the history

  9. Nix null checks in favor of serializeNulls

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    dea9c0b View commit details
    Browse the repository at this point in the history

  10. Inline null checks and fail eagerly

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    263be76 View commit details
    Browse the repository at this point in the history

  11. Fix double _Adapter

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    7f5efd6 View commit details
    Browse the repository at this point in the history

  12. First pass at simplifying adapter names

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    4132192 View commit details
    Browse the repository at this point in the history

  13. Inline names to options property, life into class and rm companion

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    1f08c70 View commit details
    Browse the repository at this point in the history

  14. Differentiate between absent and null, use nullSafe() as needed

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    428917d View commit details
    Browse the repository at this point in the history

  15. Group together compile and test dependencies

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    dc8647f View commit details
    Browse the repository at this point in the history

  16. Remove incorrect comment

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    917ae9b View commit details
    Browse the repository at this point in the history

  17. Revert formatting

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    62a9f1b View commit details
    Browse the repository at this point in the history

  18. Set, not mutable set

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    ef4cdd6 View commit details
    Browse the repository at this point in the history

  19. Collapse else-if nesting to one when

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    9445169 View commit details
    Browse the repository at this point in the history

  20. Cleaner formatting test code

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    a987697 View commit details
    Browse the repository at this point in the history

  21. Collapse more to locals

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    12857e1 View commit details
    Browse the repository at this point in the history

  22. Collapse more

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    449667b View commit details
    Browse the repository at this point in the history

  23. Return a nonnullable type in fromJson

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    960f85e View commit details
    Browse the repository at this point in the history

  24. Remove redundant out variance

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    d175897 View commit details
    Browse the repository at this point in the history

  25. Use KClass where appropriate

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    0390cc5 View commit details
    Browse the repository at this point in the history

  26. End comment in period

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    999e3fc View commit details
    Browse the repository at this point in the history

  27. Remove redundant comment

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    0702fc7 View commit details
    Browse the repository at this point in the history

  28. Throw on unrecognized type in simplified name

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    e090521 View commit details
    Browse the repository at this point in the history

  29. Use illegalargumentexception instead

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    1fec18a View commit details
    Browse the repository at this point in the history

  30. Emit a nullcheck at the beginning of toJson instead

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    5ddf528 View commit details
    Browse the repository at this point in the history

  31. Remove extra newline

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    b59f36a View commit details
    Browse the repository at this point in the history

  32. Simplify processing to be less abusive

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    a33d46c View commit details
    Browse the repository at this point in the history

  33. Skip using asClassName() when possible

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    9a34bb0 View commit details
    Browse the repository at this point in the history

  34. Use addComment()

    @ZacSweers
    ZacSweers committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    7525f89 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2018

  1. Switch to declared constructors 

    Technically more correct since we're defining these
    @ZacSweers
    ZacSweers committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    5597b91 View commit details
    Browse the repository at this point in the history

  2. Unmodifiable set

    @ZacSweers
    ZacSweers committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    d877e88 View commit details
    Browse the repository at this point in the history

  3. return adapter(type, annotationTypes[0])

    @ZacSweers
    ZacSweers committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    5ed2a58 View commit details
    Browse the repository at this point in the history

  4. Slight optimization - check if the type is parameterized first 

    If the type is a parameterized type, then we know they'll have the two-arg constructor. This way we don't always try and fail the single arg constructor on parameterized types
    @ZacSweers
    ZacSweers committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    67f4ab1 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2018

  1. Add test for type aliases, optimize to reuse adapters if possible 

    This is a tiny optimization to make type aliases (which did already work) reuse adapter properties if they already exist for the backing type. What this means is that if you have:

typealias Foo = String

and properties
foo: Foo
bar: String

you'll only get one adapter property field for String, and both will use it
    @ZacSweers
    ZacSweers committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    9b6e78b View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2018

  1. Use string templating where possible

    @ZacSweers
    ZacSweers committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    a9ae13a View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2018

  1. Remove all the kotshi tests

    @ZacSweers
    ZacSweers committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    31b11f0 View commit details
    Browse the repository at this point in the history