Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessor methods on HttpUrl.Builder #2171

Closed
JakeWharton opened this issue Dec 29, 2015 · 1 comment
Closed

Accessor methods on HttpUrl.Builder #2171

JakeWharton opened this issue Dec 29, 2015 · 1 comment
Milestone

Comments

@JakeWharton
Copy link
Member

Enough to fulfill Retrofit's need of doing path replacement with proper encoding on an instance.

@JakeWharton JakeWharton added this to the 3.0 milestone Dec 29, 2015
@swankjesse
Copy link
Member

After further investigation it looks like it’s difficult to get an API that works the way Retrofit wants. In particular a path like @Get("/{foo}{bar}") might be problematic if foo is encoded already and bar is not. That sends us down the ugly road of offering one-off encoding and decoding methods, which I’m not eager to do.

No action to take at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants