Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OkHttpClient final does not allow mocks #2292

Closed
mreichelt opened this issue Jan 28, 2016 · 1 comment
Closed

OkHttpClient final does not allow mocks #2292

mreichelt opened this issue Jan 28, 2016 · 1 comment

Comments

@mreichelt
Copy link
Contributor

The OkHttpClient class in OkHttp 3.0 is marked as final, and therefore can not be extended nor mocked (e.g. by using Mockito).
mreichelt added a commit to mreichelt/okhttp that referenced this issue Jan 28, 2016
@mreichelt
square#2292 removed final from OkHttpClient
425167a
@mreichelt mreichelt mentioned this issue Jan 28, 2016
Merged
swankjesse added a commit that referenced this issue Jan 28, 2016
@swankjesse
Merge pull request #2293 from mreichelt/2292-okhttpclient-final
38ddfed 
#2292 removed final from OkHttpClient
@ghost
Copy link

ghost commented Jan 28, 2016

@swankjesse Thanks a lot! I hope 3.1.0 will be released soon so I can complete our migration from 2 to 3. :)

@azell azell mentioned this issue Jan 30, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swankjesse @mreichelt