Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handshake certificates are unclean #5138

Closed
swankjesse opened this issue May 28, 2019 · 3 comments
Closed

Handshake certificates are unclean #5138

swankjesse opened this issue May 28, 2019 · 3 comments
Labels
enhancement Feature not a bug
Milestone
4.2

Comments

@swankjesse
Copy link
Member

We’re cleaning them for the certificate Pinner but not otherwise. We should put cleaned certificates into the handshake always.

Only need to be careful of the performance consequences of this.

babylonhealth/certificate-transparency-android#4 (comment)
@swankjesse swankjesse added the enhancement Feature not a bug label May 28, 2019
@swankjesse swankjesse added this to the Backlog milestone Jun 15, 2019
@yschimke
Copy link
Collaborator

yschimke commented Jul 29, 2019 •
edited
Loading

This is a good candidate for 4.1, I'll take a look at it this week.

@yschimke yschimke mentioned this issue Jul 29, 2019
Merged
@yschimke
Copy link
Collaborator

Draft PR, will add tests, feel free to comment on approach.

https://github.com/square/okhttp/pull/5311/files

@yschimke yschimke modified the milestones: Backlog, 4.1, 4.2 Jul 29, 2019
@swankjesse
Copy link
Member Author

Shipped in 4.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature not a bug
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
2 participants
@swankjesse @yschimke