Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Envoy Mobile experiment #6800

Closed
wants to merge 8 commits into from
Closed

Envoy Mobile experiment #6800

wants to merge 8 commits into from

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Jul 31, 2021 •
edited
Loading

Quic prototype of the code to bridge between OkHttp and EnvoyMobile

Blocked on binary aar dependency envoyproxy/envoy-mobile#1651

Also only runs on SDK 24 and x86. aar does not include other platforms and isn't working on recent Android versions.

@yschimke yschimke added the android-regression Run a PR against regression tests label Jul 31, 2021
@yschimke
Copy link
Collaborator Author 

2021-07-31 11:25:42.455 6082-6097/okhttp.regression.test I/System.out: Response{protocol=quic, code=200, message=200, url=https://api.lyft.com/ping}
2021-07-31 11:25:42.455 6082-6097/okhttp.regression.test I/System.out: x-envoy-local-reply: true
2021-07-31 11:25:42.455 6082-6097/okhttp.regression.test I/System.out: :status: 200
2021-07-31 11:25:42.455 6082-6097/okhttp.regression.test I/System.out: x-envoy-attempt-count: 1
2021-07-31 11:25:42.456 6082-6097/okhttp.regression.test I/System.out: content-type: application/json
2021-07-31 11:25:42.456 6082-6097/okhttp.regression.test I/System.out: date: Sat
2021-07-31 11:25:42.456 6082-6097/okhttp.regression.test I/System.out: date: 31 Jul 2021 08:25:42 GMT
2021-07-31 11:25:42.456 6082-6097/okhttp.regression.test I/System.out: server: envoy
2021-07-31 11:25:42.456 6082-6097/okhttp.regression.test I/System.out: content-length: 2
2021-07-31 11:25:42.456 6082-6097/okhttp.regression.test I/System.out: x-envoy-upstream-service-time: 775
2021-07-31 11:25:42.456 6082-6097/okhttp.regression.test I/System.out: application/json
2021-07-31 11:25:42.456 6082-6097/okhttp.regression.test I/System.out: {}

Goooler
Goooler reviewed Jul 31, 2021
View reviewed changes
regression-test/build.gradle.kts
@@ -42,6 +42,8 @@ dependencies {
implementation("com.squareup.okhttp3:okhttp-tls:${okhttpLegacyVersion}") {
exclude("org.bouncycastle")
}
implementation(files("lib/envoy-0.4.0.04282021.aar"))
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.0")
Copy link
Contributor

@Goooler Goooler Jul 31, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move coroutines into Dependencies ? And its latest version should be 1.5.1.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, but this is just a draft. No plans to land in current form with a chunky aar file on the branch.

@yschimke yschimke added android-regression Run a PR against regression tests and removed android-regression Run a PR against regression tests labels Jul 31, 2021
@yschimke yschimke closed this Oct 13, 2021
@yschimke yschimke deleted the envoymobile branch October 15, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goooler Goooler Goooler left review comments

Assignees
No one assigned
Labels
android-regression Run a PR against regression tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yschimke @Goooler