-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Http2 test to be less flaky #6818
Conversation
Existing Failure
Ongoing saga of #4836 |
New failure
|
@swankjesse landing as it seems to reduce flakes after some builds. Will observe, and follow up with any concerns or review comments. |
|
||
assertThat(bodies.remove()).isEqualTo("DEF"); | ||
|
||
if (errors.isEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will do. I wanted to get something in so we have PR and master with working builds. So I hope you forgive my hackish attempt to start!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will get familiar with QueueDispatcher, there are a couple more flaky tests here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I prefer LinkedBlockingDeque over CountDownLatch for tests like this; I think it’s easier to follow.
I'm due to come back and fix this, it's sitting in my github notification queue taunting me for months now. But glad I've fixed for now, even in a hacky way, as my priority was green PR builds. I will get to it though :) |
No description provided.