Use bouncy castle to generate certs for TLS. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because there are no platform APIs to generate certificates, this needs a third party library (bouncy castle) to do the heavy lifting. Each target platform has its own built-in crypto library: - The JVM has its own internal crypto library. It uses key stores like "JCA". - Android has its own internal crypto library that's based on bouncy castle. It is repackaged in com.android and is not used by this code. With this change, okhttp brings its own copy of bouncy castle for cert generation. Once the certificate is generated we're done with bouncy castle, and use the platform libraries for TLS. This approach allows us to use one codebase on either platform.
JakeWharton
added a commit
that referenced
this pull request
Aug 1, 2012
Use bouncy castle to generate certs for TLS.
| RecordedRequest request = server.takeRequest(); | ||
| assertEquals("GET /foo HTTP/1.1", request.getRequestLine()); | ||
| } | ||
|
|
||
| // public void testConnectViaHttpsReusingConnections() throws IOException, InterruptedException { |
There was a problem hiding this comment.
this test coming in another pull?
There was a problem hiding this comment.
Yeah, there's a bunch of 'em still to uncomment:
https://github.com/square/okhttp/blob/33a0c620e1c1997ece0ee3382ad3e2145ee061a8/src/test/java/libcore/net/http/URLConnectionTest.java
I commented out these tests when I split okhttp off from HttpURLConnection. Now that I have TLS, I can put them back.
This was referenced Jan 28, 2015
This was referenced Apr 7, 2022
Closed
This was referenced Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because there are no platform APIs to generate certificates,
this needs a third party library (bouncy castle) to do the
heavy lifting.
Each target platform has its own built-in crypto library:
key stores like "JCA".
based on bouncy castle. It is repackaged in com.android
and is not used by this code.
With this change, okhttp brings its own copy of bouncy castle
for cert generation. Once the certificate is generated we're
done with bouncy castle, and use the platform libraries for TLS.
This approach allows us to use one codebase on either platform.