Support Froyo. #12
Merged
Support Froyo. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try { | ||
| return new String(out, 0, index, "US-ASCII"); | ||
| } catch (UnsupportedEncodingException e) { | ||
| throw new AssertionError(); |
There was a problem hiding this comment.
AssertionError means 'this code is unreachable'. I could wrap 'e' but it's mostly academic; because the code is unreachable. This would only trigger on a hypothetical runtime that doesn't include the "US-ASCII" charset, a charset that's required by the spec. (similarly for ISO-8859-1 and UTF-8).
That said, I do like including the 'e' so I'll fix that.
This makes a bunch of sad changes for compatibility: - Using String.length() rather than String.isEmpty() - Using String.getBytes(String) rather than String.getBytes(Charset) - Using new String(..., String) rather than new String(..., Charset) - Avoiding TimeUnit.DAYS I've tested this and the HTTP tests run perfectly fine on Froyo. The HTTPS tests time out due to a bug in Froyo that prevents its TLS library from working as a server. I manually verified that TLS works as a client without problem. I also tested this on Gingerbread. It passes all tests except for testConnectViaHttpProxyToHttpsUsingProxySystemProperty, which fails because of a bug in Gingerbread's java.net.ProxySelector. This change introduces caching reflective objects for NPN access. That'll make clients that make multiple SSL connections slightly more efficient.
ghost
merged commit 
This was referenced Jan 28, 2015
This was referenced Apr 7, 2022
Closed
This was referenced Jul 7, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a bunch of sad changes for compatibility:
I've tested this and the HTTP tests run perfectly fine on Froyo.
The HTTPS tests time out due to a bug in Froyo that prevents
its TLS library from working as a server. I manually verified
that TLS works as a client without problem.
I also tested this on Gingerbread. It passes all tests except
for testConnectViaHttpProxyToHttpsUsingProxySystemProperty, which
fails because of a bug in Gingerbread's java.net.ProxySelector.
This change introduces caching reflective objects for NPN access.
That'll make clients that make multiple SSL connections slightly
more efficient.