Update RealConnection.java #5011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-create the connection when Proxy server closes the connection after an unauthorized request, to avoid IO issue with closed socket.
|
Please don’t combine behavior changes with refactorings. Ie. don’t extract methods. Please include a test case that fails without the behavior change. |
Added test that fails when proxy server closes the connection after 407 response.
Reverted refactors.
|
I have reverted the method extraction (refactor) to ease the change tracking. Is it enough? |
yschimke
reviewed
Jan 5, 2020
| if (tunnelRequest != null) continue; | ||
| if (tunnelRequest != null) { | ||
| String header = response.header("Connection"); | ||
| if (header != null && header.toLowerCase().contains("close")) { |
There was a problem hiding this comment.
.contains() seems a bit weak here, value is generally keep-alive or close.
|
Any plans to migrate this to kotlin? Seems like a useful fix, but not essential (it should recover anyway) unless you suffer this daily with additional latency and timeouts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-create the connection when Proxy server closes the connection after an unauthorized request, to avoid IO issue with closed socket.