Make it easier to decode PEM files #5427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Sep 7, 2019
| import java.util.Date | ||
| import java.util.UUID | ||
| import java.util.concurrent.TimeUnit | ||
| import java.util.regex.Pattern |
There was a problem hiding this comment.
Why not use kotlin APIs here?
There was a problem hiding this comment.
Just habit. Migrated to Kotlin APIs and they fit this problem even better.
yschimke
approved these changes
Sep 7, 2019
I'm starting with the thing I want first; reusing a HeldCertificate across VM invocations. Later we might want to create entire HandshakeCertificates objects by stringing together many certificates from a single file.
swankjesse
force-pushed
the
jwilson.0905.decode_pems
branch
from
3e0639e
to
93c5bcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting with the thing I want first; reusing a HeldCertificate
across VM invocations.
Later we might want to create entire HandshakeCertificates objects
by stringing together many certificates from a single file.