Acknowledge and apply inbound settings atomically #5431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #5422 Unfortunately testing this is awkward because it's racy. I did run a stress test that used to reproduce the problem, and now it doesn't, so I am satisfied.
swankjesse
commented
Sep 8, 2019
| * execute all peer settings logic on the writer thread. This relies on the fact that the | ||
| * writer executor won't reorder tasks; otherwise settings could be applied in the opposite | ||
| * order than received. | ||
| */ |
There was a problem hiding this comment.
this function diffs better with GitHub’s Hide whitespace changes setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5422
Unfortunately testing this is awkward because it's racy. I did
run a stress test that used to reproduce the problem, and now it
doesn't, so I am satisfied.