Fix connection pooling for different clients with the same pool. #5520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
force-pushed
the
jwilson.1001.fix_pooling
branch
from
3497f02
to
23a7df0
Compare
swankjesse
commented
Oct 2, 2019
| @@ -163,9 +163,9 @@ open class OkHttpClient internal constructor( | |||
|
|
|||
| @get:JvmName("proxySelector") val proxySelector: ProxySelector = | |||
| when { | |||
| // Avoid possible SecurityException from ProxySelector.getDefault | |||
| builder.proxy != null -> NullProxySelector() | |||
| else -> builder.proxySelector ?: ProxySelector.getDefault() ?: NullProxySelector() | |||
There was a problem hiding this comment.
these NullProxySelector instances weren’t equal to each other!
swankjesse
force-pushed
the
jwilson.1001.fix_pooling
branch
from
23a7df0
to
499bbc4
Compare
|
LGTM. On mobile. |
|
All good. SecurityManager is bad and we should discourage it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5519