Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a regression closing WebSockets before connect #5707

Merged
merged 1 commit into from Jan 7, 2020
Merged

Fix a regression closing WebSockets before connect #5707

merged 1 commit into from Jan 7, 2020

Conversation

swankjesse
Copy link
Member

Closes: #5705

@swankjesse swankjesse mentioned this pull request Jan 7, 2020
Closed
@swankjesse
Copy link
Member Author

closeReasonMaximumLength - okhttp3.internal.ws.WebSocketHttpTest

org.junit.ComparisonFailure: expected:<[0]> but was:<[1]>
	at okhttp3.OkHttpClientTestRule.ensureAllConnectionsReleased(OkHttpClientTestRule.kt:91)
	at okhttp3.OkHttpClientTestRule$apply$1.evaluate(OkHttpClientTestRule.kt:121)

serverCloseThenClientClose - okhttp3.internal.ws.RealWebSocketTest

java.lang.AssertionError: 
Expecting empty but was:<[Closed[1000 Hello!]]>
	at okhttp3.internal.ws.WebSocketRecorder.assertExhausted(WebSocketRecorder.java:163)
	at okhttp3.internal.ws.RealWebSocketTest.tearDown(RealWebSocketTest.java:58)

@swankjesse swankjesse merged commit 1e02ecd into master Jan 7, 2020
@oldergod oldergod deleted the jwilson.0106.close_without_connect_ branch March 7, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeWharton JakeWharton JakeWharton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RealWebSocket send throws writerTask NPE
2 participants
@swankjesse @JakeWharton