Fix Android tests #6408
Fix Android tests #6408
Conversation
yschimke
commented
Nov 8, 2020
•
yschimke
commented
- Junit 5
- bouncy castle fixes
- lets encrypt test
|
The bouncy castle dependencies are not a pretty read for our purposes https://bouncycastle.org/latest_releases.html Two sets of jars with different artifact names and the existing one (jdk15) now includes JDK15 classes that break OkHttp. We now need to use jdk15to18. |
|
https://github.com/mannodermaus/android-junit5
|
| /** | ||
| * Test for new Let's Encrypt Root Certificate. | ||
| */ | ||
| class LetsEncryptClientTest { |
There was a problem hiding this comment.
Example code for fixing #6403
# Conflicts: # android-test/build.gradle
# Conflicts: # regression-test/src/androidTest/java/okhttp/regression/compare/ApacheHttpClientTest.kt # regression-test/src/androidTest/java/okhttp/regression/compare/OkHttpClientTest.kt
| """.trimIndent().decodeCertificatePem() | ||
|
|
||
| val handshakeCertificates = HandshakeCertificates.Builder() | ||
| // TODO reenable in official answers |
There was a problem hiding this comment.
should this be in our samples directory?
There was a problem hiding this comment.
I think (awkwardly), we validly want 3:
- Regression test - test against older versions
- Android test - test modern version using okhttp-tls etc
- Sample for other cases and documentation
