Do not merge: show API diffs since 4.9.3 #7116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swankjesse
commented
Feb 26, 2022
| @@ -21,6 +21,7 @@ public final class okhttp3/mockwebserver/MockResponse : java/lang/Cloneable { | |||
| public fun clone ()Lokhttp3/mockwebserver/MockResponse; | |||
| public final fun getBody ()Lokio/Buffer; | |||
| public final fun getBodyDelay (Ljava/util/concurrent/TimeUnit;)J | |||
| public final fun getDuplexResponseBody ()Lokhttp3/mockwebserver/internal/duplex/DuplexResponseBody; | |||
There was a problem hiding this comment.
green = removal since 4.9.3
swankjesse
commented
Feb 26, 2022
| @@ -74,17 +77,12 @@ public final class okhttp3/mockwebserver/MockWebServer : org/junit/rules/Externa | |||
| public fun close ()V | |||
| public final fun enqueue (Lokhttp3/mockwebserver/MockResponse;)V | |||
| public final fun getBodyLimit ()J | |||
| public static fun getBodyLimit$delegate (Lokhttp3/mockwebserver/MockWebServer;)Ljava/lang/Object; | |||
| public final fun getDelegate ()Lmockwebserver3/MockWebServer; | |||
There was a problem hiding this comment.
These are new since 4.9.3
There was a problem hiding this comment.
It would be nice if we could remove some of these, for example methods with $ or -. Would give a much clearer idea of the API.
swankjesse
commented
Feb 26, 2022
| public fun <init> ()V | ||
| public fun dispatch (Lokhttp3/mockwebserver/RecordedRequest;)Lokhttp3/mockwebserver/MockResponse; | ||
| public final fun enqueueResponse (Lokhttp3/mockwebserver/MockResponse;)V | ||
| public fun enqueueResponse (Lokhttp3/mockwebserver/MockResponse;)V |
There was a problem hiding this comment.
this API is made final since 4.9.3
There was a problem hiding this comment.
Could you point out the diff where this happened?
swankjesse
commented
Feb 26, 2022
| public final fun setFailFast (Lokhttp3/mockwebserver/MockResponse;)V | ||
| public final fun setFailFast (Z)V | ||
| public fun setFailFast (Lokhttp3/mockwebserver/MockResponse;)V | ||
| public fun setFailFast (Z)V |
There was a problem hiding this comment.
these also made final
swankjesse
commented
Feb 26, 2022
| @@ -176,3 +178,22 @@ public final class okhttp3/mockwebserver/SocketPolicy : java/lang/Enum { | |||
| public static fun values ()[Lokhttp3/mockwebserver/SocketPolicy; | |||
| } | |||
|
|
|||
| public abstract interface class okhttp3/mockwebserver/internal/duplex/DuplexResponseBody { | |||
There was a problem hiding this comment.
please disregard internal I didn’t prune these
swankjesse
commented
Feb 26, 2022
| @@ -103,11 +102,8 @@ public final class okhttp3/CacheControl$Builder { | |||
| public final fun build ()Lokhttp3/CacheControl; | |||
| public final fun immutable ()Lokhttp3/CacheControl$Builder; | |||
| public final fun maxAge (ILjava/util/concurrent/TimeUnit;)Lokhttp3/CacheControl$Builder; | |||
| public final fun maxAge (ILkotlin/time/DurationUnit;)Lokhttp3/CacheControl$Builder; | |||
|
Diffs all look good as far as I’m concerned. |
yschimke
reviewed
Feb 26, 2022
| @@ -739,6 +735,7 @@ public final class okhttp3/MediaType { | |||
| public static final field Companion Lokhttp3/MediaType$Companion; | |||
| public final fun -deprecated_subtype ()Ljava/lang/String; | |||
| public final fun -deprecated_type ()Ljava/lang/String; | |||
| public synthetic fun <init> (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;[Ljava/lang/String;Lkotlin/jvm/internal/DefaultConstructorMarker;)V | |||
There was a problem hiding this comment.
Interesting, these look like a compiler bug Kotlin/binary-compatibility-validator#73
yschimke
reviewed
Feb 26, 2022
| public final fun followRedirects ()Z | ||
| public final fun followSslRedirects ()Z | ||
| public final fun getRouteDatabase ()Lokhttp3/internal/connection/RouteDatabase; |
yschimke
reviewed
Feb 26, 2022
| @@ -975,7 +970,6 @@ public final class okhttp3/Request { | |||
| public final fun -deprecated_url ()Lokhttp3/HttpUrl; | |||
| public final fun body ()Lokhttp3/RequestBody; | |||
| public final fun cacheControl ()Lokhttp3/CacheControl; | |||
| public final fun getTags ()Ljava/util/Map; | |||
There was a problem hiding this comment.
you flagged this elsewhere.
|
Thanks for the close reading of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.