Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimise HttpOverHttp2Test flakes #8207

Merged
merged 2 commits into from Jan 20, 2024
Merged

Minimise HttpOverHttp2Test flakes #8207

merged 2 commits into from Jan 20, 2024

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Jan 20, 2024 •
edited

First step of #8206

@yschimke
Copy link
Collaborator Author

@swankjesse will land if passing regularly, and follow up to fix tests

@yschimke
Copy link
Collaborator Author

Lets see if this fixes things...

@yschimke yschimke merged commit f6600e5 into square:master Jan 20, 2024
20 checks passed
@yschimke
Copy link
Collaborator Author

Still failing on https://github.com/square/okhttp/actions/runs/7605856252/job/20710735098

HttpOverHttp2Test > concurrentRequestWithEmptyFlowControlWindow(Protocol, MockWebServer) > [1] h2_prior_knowledge FAILED
    java.lang.AssertionError: Timed out waiting for log message.
        at okhttp3.TestLogHandler.take(TestLogHandler.kt:92)
        at okhttp3.internal.http2.HttpOverHttp2Test.waitForDataFrames(HttpOverHttp2Test.kt:426)
        at okhttp3.internal.http2.HttpOverHttp2Test.concurrentRequestWithEmptyFlowControlWindow(HttpOverHttp2Test.kt:482)

HttpOverHttp2Test > connectionWindowUpdateOnClose(Protocol, MockWebServer) > [1] h2_prior_knowledge FAILED
    java.lang.AssertionError: Timed out waiting for log message.
        at okhttp3.TestLogHandler.take(TestLogHandler.kt:92)
        at okhttp3.internal.http2.HttpOverHttp2Test.waitForDataFrames(HttpOverHttp2Test.kt:426)
        at okhttp3.internal.http2.HttpOverHttp2Test.connectionWindowUpdateOnClose(HttpOverHttp2Test.kt:454)

Still failing on https://github.com/square/okhttp/actions/runs/7605856252/job/20710735792

HttpOverHttp2Test > connectionWindowUpdateAfterCanceling(Protocol, MockWebServer) > [1] h2_prior_knowledge FAILED
    java.lang.AssertionError: Timed out waiting for log message.
        at okhttp3.TestLogHandler.take(TestLogHandler.kt:92)
        at okhttp3.internal.http2.HttpOverHttp2Test.waitForDataFrames(HttpOverHttp2Test.kt:426)
        at okhttp3.internal.http2.HttpOverHttp2Test.connectionWindowUpdateAfterCanceling(HttpOverHttp2Test.kt:407)

So fix is just for Windows.

swankjesse
swankjesse reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@swankjesse swankjesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs something!

okhttp/src/test/java/okhttp3/internal/http2/HttpOverHttp2Test.kt
}

@AfterEach fun tearDown() {
// TODO reenable after https://github.com/square/okhttp/issues/8206
// fileSystem.checkNoOpenFiles()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can’t leave a TODO: re-enable after X when X is already closed; that’s cheating!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, true. I'll bite the bullet and look again!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8230

@yschimke yschimke mentioned this pull request Jan 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swankjesse swankjesse swankjesse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yschimke @swankjesse