Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test using Http/3 #8304

Merged
merged 4 commits into from
Mar 24, 2024
Merged

Test using Http/3 #8304

merged 4 commits into from
Mar 24, 2024

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Mar 24, 2024

Comparing results between HttpClient h3 and OkHttp.

Enable HTTP/3

@yschimke yschimke added the android-regression Run a PR against regression tests label Mar 24, 2024
@yschimke yschimke marked this pull request as ready for review March 24, 2024 12:41
@@ -57,10 +57,9 @@ class AndroidHttpEngineTest {
}
val engine =
HttpEngine.Builder(context)
.setEnableHttp2(true)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default to true

@yschimke
Copy link
Collaborator Author

@swankjesse test only

@yschimke yschimke merged commit 573bdaa into square:master Mar 24, 2024
21 checks passed
Copy link
Member

@swankjesse swankjesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Neat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-regression Run a PR against regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants