Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change parameter order for Cache constructor #8338

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Change parameter order for Cache constructor #8338

merged 4 commits into from
Apr 10, 2024

Conversation

swankjesse
Copy link
Member

Put FileSystem before Path, as is convention.

Also put this new constructor in the public API.

@swankjesse
Change parameter order for Cache constructor
08f1b68 
Put FileSystem before Path, as is convention.

Also put this new constructor in the public API.
JakeWharton
JakeWharton approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither Zipline nor Redwood put the FileSystem before the Path. File bugs on both to update?

@swankjesse
Copy link
Member Author

Good idea.
cashapp/redwood#1942
cashapp/zipline#1283

@swankjesse swankjesse merged commit d2e91f7 into master Apr 10, 2024
20 checks passed
@swankjesse swankjesse deleted the jwilson.0405.cache_path_not_experimental branch April 10, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeWharton JakeWharton JakeWharton approved these changes

@yschimke yschimke yschimke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@swankjesse @JakeWharton @yschimke