Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract a test thread factory #8356

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

swankjesse
Copy link
Member

This is different from the production thread factory:

  • No daemon threads in tests. We don't need 'em.
  • Threads are numbered in tests. We do need that.

@swankjesse swankjesse requested a review from ean5533 April 11, 2024 01:59
Base automatically changed from jwilson.0407.taskfaker to master April 11, 2024 01:59
This is different from the production thread factory:
 - No daemon threads in tests. We don't need 'em.
 - Threads are numbered in tests. We do need that.
@swankjesse swankjesse merged commit 822bad8 into master Apr 11, 2024
20 checks passed
@swankjesse swankjesse deleted the jwilson.0410.threadfactory branch April 11, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants