Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConnectionPoolTest bug #8384

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix ConnectionPoolTest bug #8384

merged 1 commit into from
Apr 24, 2024

Conversation

ean5533
Copy link
Collaborator

@ean5533 ean5533 commented Apr 23, 2024

  1. Advance taskFaker time forward to the present when the test starts.
  2. Stop having multiple factories and taskfakers floating around.

1. Advance taskFaker time forward to the present when the test starts.
2. Stop having multiple factories and taskfakers floating around.
@yschimke yschimke merged commit aede7c5 into master Apr 24, 2024
20 checks passed
@yschimke yschimke deleted the enelson-fix branch April 24, 2024 04:40
@yschimke
Copy link
Collaborator

I merged because it looked to be passing

But still seeing failures.

ConnectionPoolTest > connectionPreWarmingHttp2() FAILED
    org.opentest4j.AssertionFailedError: expected:<[2]> but was:<[1]>
        at app//okhttp3.internal.connection.ConnectionPoolTest.connectionPreWarmingHttp2(ConnectionPoolTest.kt:258)

@ean5533
Copy link
Collaborator Author

ean5533 commented Apr 24, 2024

Yup, I'm working on that now, just wanted to get these easy wins merged in first. I've found the root cause of the flakiness in that test (the use of TaskRunner.INSTANCE in Http2Connection.Builder) but I'm not yet sure how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants