General project clean-up and tweaks. #9
Conversation
JakeWharton
commented
Jul 28, 2012
JakeWharton
commented
- Add checkstyle and correct anything that failed.
- Expand README.md to have more info for the upcoming release.
- Resolve plugin warnings in pom.xml.
* Add checkstyle and correct anything that failed. * Expand README.md to have more info for the upcoming release. * Resolve plugin warnings in pom.xml.
| `checkstyle-result.xml` file. | ||
|
|
||
| Before your code can be accepted into the project you must also sign the |
There was a problem hiding this comment.
Nice.
We should get our contributors to sign both Square's ICLA and Android's CLA just to be safe.
|
Awesome. One important constraint of okhttp is that it's intended to be upstream of AOSP. Basically every change we make in okhttp should be followed by an AOSP gerrit request. Unfortunately we're already sitting on one huge unmerged change. This is the change that extracts a 'Transport' interface and adds a SpdyTransport implementation. We can't contribute this to AOSP until our legal agreements are approved, and we're still waiting on that. We want our first AOSP contribution to be as small as possible, especially since it includes some renamed files and actual merging might be nontrivial. ... so although I'm merging this, I'll also exclude it from the initial upstream merge. We'll follow that big change with a follow up that includes this change. All that said, git makes it easy to slice & dice patches so it shouldn't be a problem. |
General project clean-up and tweaks.
