Fix Closeable.use NullPointerException (#1453)

* Fix Cloneable.use NullPointerException * Add assertNull
square · Mar 5, 2024 · fe6ac99 · fe6ac99
1 parent 940496a
commit fe6ac99
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/okio/src/commonMain/kotlin/okio/Okio.kt b/okio/src/commonMain/kotlin/okio/Okio.kt
@@ -49,13 +49,13 @@ private class BlackholeSink : Sink {
 
 /** Execute [block] then close this. This will be closed even if [block] throws. */
 inline fun <T : Closeable?, R> T.use(block: (T) -> R): R {
-  var result: R? = null
   var thrown: Throwable? = null
 
-  try {
-    result = block(this)
+  val result = try {
+    block(this)
   } catch (t: Throwable) {
     thrown = t
+    null
   } finally {
     try {
       this?.close()
@@ -69,5 +69,6 @@ inline fun <T : Closeable?, R> T.use(block: (T) -> R): R {
   }
 
   if (thrown != null) throw thrown
-  return result!!
+  @Suppress("UNCHECKED_CAST")
+  return result as R
 }
diff --git a/okio/src/nonWasmTest/kotlin/okio/UseTest.kt b/okio/src/nonWasmTest/kotlin/okio/UseTest.kt
@@ -1,6 +1,7 @@
 package okio
 
 import kotlin.test.Test
+import kotlin.test.assertNull
 import okio.Path.Companion.toPath
 import okio.fakefilesystem.FakeFileSystem
 
@@ -25,4 +26,13 @@ class UseTest {
 
     fakeFileSystem.checkNoOpenFiles()
   }
+
+  @Test
+  fun acceptsNullReturn() {
+    val result = object : Closeable {
+      override fun close() {}
+    }.use { null }
+
+    assertNull(result)
+  }
 }