Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure close is called in all use cases. #1188

Closed
wants to merge 6 commits into from
Closed

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Jan 4, 2023

A non local return from the inline function was skipping the close.

Addresses #1187

@swankjesse swankjesse closed this Jan 4, 2023
@swankjesse swankjesse reopened this Jan 4, 2023
@swankjesse
Copy link
Member

Ooooh I hate that this fix is necessary.

@yschimke
Copy link
Collaborator Author

yschimke commented Jan 5, 2023

Failure looks load+timeout related

okio.PipeTest[jvm] > sourceBlocksOnSlowWriter[jvm] FAILED
    java.lang.AssertionError: expected:<4000.0> but was:<4299.10836899979>
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:555)
        at org.junit.Assert.assertEquals(Assert.java:685)
        at okio.PipeTest.assertElapsed(PipeTest.java:374)
        at okio.PipeTest.sourceBlocksOnSlowWriter(PipeTest.java:361)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants