Don't throw in awaitSignal if the timeout is canceled #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
Dec 15, 2023
Comment on lines
+201
to
+208
| // If there's time remaining, we probably got the call we were waiting for. | ||
| if (nanosRemaining > 0) return | ||
|
|
||
| // Return without throwing if this timeout was canceled while we were waiting. Note that this | ||
| // return is a 'spurious wakeup' because Condition.signal() was not called. | ||
| if (cancelMark !== cancelMarkBefore) return | ||
|
|
||
| throw InterruptedIOException("timeout") |
There was a problem hiding this comment.
Not my favorite control flow structure (within a try/catch), but probably is the most readable in the end.
There was a problem hiding this comment.
Note that this throw doesn’t get caught by the directly-enclosing try/catch. InterruptedIOException and InterruptedException are tricky.
There was a problem hiding this comment.
Yeah I was going to suggest moving the throw out of the try/catch, but then I really want the returns out of the try/catch too, but then local scoping becomes hard and it's all terrible and whatever this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.