Reduce intermediate allocations when create Options
#1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
oldergod
approved these changes
Feb 5, 2024
kyay10
reviewed
Feb 5, 2024
| @@ -40,7 +40,7 @@ class Options private constructor( | |||
| // indexes to the caller's indexes. | |||
| val list = byteStrings.toMutableList() | |||
| list.sort() | |||
| val indexes = mutableListOf(*byteStrings.map { -1 }.toTypedArray()) | |||
| val indexes = MutableList(list.size) { -1 } | |||
There was a problem hiding this comment.
This could be IntArray(list.size) { -1 }, but then the removeAt calls later wouldn't work. There's likely a way to change that logic, but it might be too much hassle.
There was a problem hiding this comment.
Yeah I didn't want to get too invasive. You would have to track the working length separately and then do a shift to simulate the removeAt. At some point it's diminishing returns since this function is only meant to be called once and then the resulting object cached for long periods of time.
swankjesse
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.