Don't check buffer exhaustion while filling ints #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The array size is already derived from the buffer size.
oldergod
reviewed
Feb 6, 2024
| while (!trieBytes.exhausted()) { | ||
| trie[i++] = trieBytes.readInt() | ||
| val trie = IntArray(trieBytes.intCount.toInt()) { | ||
| trieBytes.readInt() |
There was a problem hiding this comment.
Don't you still need to loop over it?
There was a problem hiding this comment.
This is a loop. It's called once for each position in the array.
There was a problem hiding this comment.
oooooh I misread that the previouew code wasn't doing that in the block passed to IntArray.
oldergod
approved these changes
Feb 6, 2024
| while (!trieBytes.exhausted()) { | ||
| trie[i++] = trieBytes.readInt() | ||
| val trie = IntArray(trieBytes.intCount.toInt()) { | ||
| trieBytes.readInt() |
There was a problem hiding this comment.
oooooh I misread that the previouew code wasn't doing that in the block passed to IntArray.
swankjesse
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array size is already derived from the buffer size.