Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct documentation links in ZipFileSystem.kt #1461

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

vanniktech
Copy link
Contributor

Currently, it just seems broken:

Screenshot 2024-03-28 at 10 41 16

But I think this should fix it.

okio/src/zlibMain/kotlin/okio/ZipFileSystem.kt Outdated Show resolved Hide resolved
Co-authored-by: Benoît Quenaudon <benoit@quenaudon.com>
@oldergod oldergod enabled auto-merge March 28, 2024 12:26
@oldergod
Copy link
Member

oldergod commented Mar 28, 2024

What's this? Why is there no github details bound to it?

image

@oldergod oldergod merged commit b732a82 into square:master Mar 28, 2024
11 checks passed
@msfjarvis
Copy link

What's this? Why is there no github details bound to it?

image

#1419 (comment)

GitHub still expects the macos-11 job as a required check but it no longer exists.

@JakeWharton
Copy link
Member

I had fixed it, which is why the auto-merge triggered.

Also let's try to use squash for multi-commit PRs in the future unless each commit is a separate, tested unit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants