To specify an error message explicitly for uppercase #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add a test case too? |
|
I added test case for uppercase. I thought that this test case is useless cause there's already illegalTokenCharactersFailFast test case. it's very similar.. |
Closed
pforhan
reviewed
Jul 19, 2017
| from("Hello {Name}").putOptional("Name", "Eric").format().toString(); | ||
| fail("Expected IllegalArgumentException"); | ||
| } catch (IllegalArgumentException e) { | ||
| } |
There was a problem hiding this comment.
I think the key here is to verify that the value of e.getMessage() is not Missing Closing Brace
pforhan
added a commit
to pforhan/phrase
that referenced
this pull request
Jul 21, 2017
pforhan
added a commit
to pforhan/phrase
that referenced
this pull request
Jul 21, 2017
pforhan
added a commit
to pforhan/phrase
that referenced
this pull request
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue #32